[PATCH] wifi: ath11k: remove peer extra rssi update

Vasanthakumar Thiagarajan quic_vthiagar at quicinc.com
Sat Jan 18 02:39:41 PST 2025



On 1/17/2025 11:49 PM, Nicolas Escande wrote:
> Commit b205ce4c266c (ath11k: support avg signal in station dump) added an
> extra assignment of arsta->rssi_comb in ath11k_dp_rx_update_peer_stats
> when it added the average rssi support. So lets keeps only one by removing
> the legacy assignment so the two statements about rssi stay next to each
> other. Compile tested only.
> 
> Signed-off-by: Nicolas Escande <nico.escande at gmail.com>
> ---
>   drivers/net/wireless/ath/ath11k/dp_rx.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 029ecf51c9efd..24774cba9823b 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -2831,8 +2831,6 @@ static void ath11k_dp_rx_update_peer_stats(struct ath11k_sta *arsta,
>   	rx_stats->dcm_count += ppdu_info->dcm;
>   	rx_stats->ru_alloc_cnt[ppdu_info->ru_alloc] += num_msdu;
>   
> -	arsta->rssi_comb = ppdu_info->rssi_comb;
> -
>   	BUILD_BUG_ON(ARRAY_SIZE(arsta->chain_signal) >
>   			     ARRAY_SIZE(ppdu_info->rssi_chain_pri20));
>   

Good catch!

Reviewed-by: Vasanthakumar Thiagarajan <quic_vthiagar at quicinc.com>



More information about the ath11k mailing list