[Intel-wired-lan] [PATCH net-next 5/7] wifi: mwifiex: Don't use %pK through printk

[Loktionov, Aleksandr]

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces at osuosl.org> On Behalf Of
> Thomas Weißschuh
> Sent: Monday, April 14, 2025 10:26 AM
> To: Jeff Johnson <jjohnson at kernel.org>; Loic Poulain
> <loic.poulain at linaro.org>; Brian Norris <briannorris at chromium.org>;
> Francesco Dolcini <francesco at dolcini.it>; Nguyen, Anthony L
> <anthony.l.nguyen at intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel at intel.com>; Andrew Lunn <andrew+netdev at lunn.ch>;
> David S. Miller <davem at davemloft.net>; Dumazet, Eric
> <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>; Paolo Abeni
> <pabeni at redhat.com>; Saeed Mahameed <saeedm at nvidia.com>; Leon
> Romanovsky <leon at kernel.org>; Tariq Toukan <tariqt at nvidia.com>
> Cc: ath10k at lists.infradead.org; linux-kernel at vger.kernel.org;
> ath11k at lists.infradead.org; ath12k at lists.infradead.org;
> wcn36xx at lists.infradead.org; linux-wireless at vger.kernel.org; intel-wired-
> lan at lists.osuosl.org; netdev at vger.kernel.org; linux-rdma at vger.kernel.org;
> Thomas Weißschuh <thomas.weissschuh at linutronix.de>
> Subject: [Intel-wired-lan] [PATCH net-next 5/7] wifi: mwifiex: Don't use %pK
> through printk
> 
> In the past %pK was preferable to %p as it would not leak raw pointer values
> into the kernel log.
> Since commit ad67b74d2469 ("printk: hash addresses printed with %p") the
> regular %p has been improved to avoid this issue.
> Furthermore, restricted pointers ("%pK") were never meant to be used
> through printk(). They can still unintentionally leak raw pointers or acquire
> sleeping looks in atomic contexts.
> 
> Switch to the regular pointer formatting which is safer and easier to reason
> about.
> There are still a few users of %pK left, but these use it through seq_file, for
> which its usage is safe.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh at linutronix.de>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov at intel.com>
> ---
>  drivers/net/wireless/marvell/mwifiex/pcie.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c
> b/drivers/net/wireless/marvell/mwifiex/pcie.c
> index
> dd2a42e732f2398892915e1a3ac88b7d3fb4ed3f..a760de191fce7340040b1
> bc74efb35cf52ce8368 100644
> --- a/drivers/net/wireless/marvell/mwifiex/pcie.c
> +++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
> @@ -2971,7 +2971,7 @@ static int mwifiex_init_pcie(struct mwifiex_adapter
> *adapter)
>  		goto err_iomap2;
>  	}
> 
> -	pr_notice("PCI memory map Virt0: %pK PCI memory map Virt2:
> %pK\n",
> +	pr_notice("PCI memory map Virt0: %p PCI memory map Virt2: %p\n",
>  		  card->pci_mmap, card->pci_mmap1);
> 
>  	ret = mwifiex_pcie_alloc_buffers(adapter);
> 
> --
> 2.49.0