[RFC PULL] ath11k: move WCN6750 firmware to the device-specific subdir

[Kalle Valo]

Dmitry Baryshkov <dmitry.baryshkov at linaro.org> writes:

> On Mon, 21 Oct 2024 at 21:22, Kalle Valo <kvalo at kernel.org> wrote:
>
>>
>> Jeff Johnson <quic_jjohnson at quicinc.com> writes:
>>
>> >> Dmitry Baryshkov (1):
>> >>       ath11k: move WCN6750 firmware to the device-specific subdir
>> >>
>> >>  WHENCE                                             |  12 ++----------
>> >>  ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} | Bin 5819999 -> 7463728 bytes
>> >>  ath11k/WCN6750/hw1.0/wpss.b00                      | Bin 340 -> 0 bytes
>> >>  ath11k/WCN6750/hw1.0/wpss.b01                      | Bin 6848 -> 0 bytes
>> >>  ath11k/WCN6750/hw1.0/wpss.b02                      | Bin 10300 -> 0 bytes
>> >>  ath11k/WCN6750/hw1.0/wpss.b03                      | Bin 4096 -> 0 bytes
>> >>  ath11k/WCN6750/hw1.0/wpss.b05                      | Bin 164332 -> 0 bytes
>> >>  ath11k/WCN6750/hw1.0/wpss.b06                      | Bin 266684 -> 0 bytes
>> >>  ath11k/WCN6750/hw1.0/wpss.b07                      | Bin 1176368 -> 0 bytes
>> >>  ath11k/WCN6750/hw1.0/wpss.b08                      |   0
>> >>  ath11k/WCN6750/hw1.0/wpss.mdt                      | Bin 7188 -> 0 bytes
>> >>  11 files changed, 2 insertions(+), 10 deletions(-)
>> >>  rename ath11k/WCN6750/hw1.0/{wpss.b04 => sc7280/wpss.mbn} (77%)
>>
>> So this follow basically the same directory hierarchy as you Dmitry
>> implemented for ath10k in commit 5abf259772df ("wifi: ath10k: support
>> board-specific firmware overrides"), right? Just making sure we are on
>> the same page. I think ath10k/ath11k/ath12k drivers should follow the
>> same design as much as possible.
>
> Yes, that was my goal. Having subdirs under the main dir.

Very good.

>> >>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b00
>> >>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b01
>> >>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b02
>> >>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b03
>> >>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b05
>> >>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b06
>> >>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b07
>> >>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.b08
>> >>  delete mode 100644 ath11k/WCN6750/hw1.0/wpss.mdt
>> >
>> > I'm waiting for Kalle to respond, but at a minimum I suspect our internal
>> > firmware tooling would be impacted by this change.
>>
>> Yeah, most likely we need to update our tools. But we would have to do
>> it anyway so I'm not concerned about that.
>
> Ok. If there are no concerns from your side, could you possibly
> respond with Acked-by? Then we can unblock and merge this.

Sure:

Acked-by: Kalle Valo <kvalo at kernel.org>

>> > Kalle, do you have concerns or suggestions on how to handle this issue?
>>
>> Looks good to me.
>>
>> Dmitry, if you have the time please take a look at this:
>>
>> https://patchwork.kernel.org/project/linux-wireless/cover/20241001033053.2084360-1-quic_miaoqing@quicinc.com/
>>
>> Based on a quick look it seems to do things differently and not really a
>> fan of that.
>
> Yes, I'd prefer a subdir rather than this implementation. I'll respond
> either today or tomorrow.

Thanks a lot, I appreciate you helping us.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches