ath11k: QCA6390 hw2.0: firmware crashing on ath.git master branch

[Kalle Valo]

+ aloka

Kalle Valo <kvalo at kernel.org> writes:

> Last week I updated ath.git master branch to v6.6-rc4 (from v6.5). My
> regression tests were passing without issues. But once I updated my
> daily driver laptop Dell XPS 13 9310 to ath.git master branch (tag
> ath-202310100725) the firmware started crashing daily:
>
> [71990.787525] ath11k_pci 0000:72:00.0: firmware crashed: MHI_CB_EE_RDDM
>
> This happens during resume and ath11k won't work after the crash, not
> even reload ath11k kernel modules won't help and I need to reboot the
> whole laptop.
>
> The strange part is that I haven't yet seen these crashes on Linus'
> official release (tag v6.6-rc4). I don't know if this is just a
> coincidence or the bug causing is just in ath.git master branch. I'll
> continue testing tag v6.6-rc4 to see if I see the firmware crash also
> with that.
>
> The problem here is of course that I see the crash only in average once
> per day so a git bisect is difficult. Has anyone else seen anything
> similar?

I found a reliable way to reproduce the firmware crash. I connect to my
home network, then do 'sudo service connman stop' and boom, the firmware
has crashed. I suspect it has nothing to do with connman, most likely a
simple disconnect will suffice but I didn't bother to test that.

I did a git bisect and it points to Aloka's recent commit. Luckily the
commit is only in ath-next so far and not in any release. My plan is to
submit a revert by tomorrow so that we get this fixed before pulling
ath-next into wireless-next.

e149353e6562f3e3246f75dfc4cca6a0cc5b4efc
commit e149353e6562f3e3246f75dfc4cca6a0cc5b4efc
Author:     Aloka Dixit <quic_alokad at quicinc.com>
AuthorDate: Mon Oct 9 10:13:54 2023 +0300
Commit:     Kalle Valo <quic_kvalo at quicinc.com>
CommitDate: Tue Oct 10 10:23:02 2023 +0300

    wifi: ath11k: call ath11k_mac_fils_discovery() without condition

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches