[PATCH v4 0/2] wifi: ath11k: Add coredump support

Manikanta Pubbisetty quic_mpubbise at quicinc.com
Tue Mar 14 23:14:12 PDT 2023


Hi Kalle,

Jeff & Vasanth have reviewed the changes technically.
Could you please help review the series?

Thanks,
Manikanta

On 3/15/2023 11:37 AM, Manikanta Pubbisetty wrote:
> Add support for devcoredump in the driver. This helps in capturing
> the snapshot of DDR memory that firmware uses in the event of a
> firmware assert which aids in firmware debug.
> 
> First patch in the series adds the basic coredump infrastructure to
> the driver. Second one in the series adds the support to capture MSA
> memory during firmware assert on WCN6750.
> 
> Manikanta Pubbisetty (2):
>    wifi: ath11k: Add coredump support
>    wifi: ath11k: Add coredump support of MSA region for WCN6750
> ---
> V4:
>   - Updated the commit log in the cover-letter
> 
> V3:
>   - Moved the modparam to core.h and removed FIXME
>   - Driver continues to work even if coredump memory allocation fails
> 
> V2:
>   - struct ath11k_ramdump_hdr::start is now u64
>   - Added missing mutex_unlock() in ath11k_ahb_coredump_msa()
>   - Corrected hdr->length assignments in ath11k_ahb_coredump_msa()
> 
>   drivers/net/wireless/ath/ath11k/Kconfig    |   1 +
>   drivers/net/wireless/ath/ath11k/Makefile   |   1 +
>   drivers/net/wireless/ath/ath11k/ahb.c      | 127 +++++++++++-
>   drivers/net/wireless/ath/ath11k/ahb.h      |   8 +-
>   drivers/net/wireless/ath/ath11k/core.c     |  18 +-
>   drivers/net/wireless/ath/ath11k/core.h     |  19 +-
>   drivers/net/wireless/ath/ath11k/coredump.c | 225 +++++++++++++++++++++
>   drivers/net/wireless/ath/ath11k/coredump.h | 147 ++++++++++++++
>   8 files changed, 541 insertions(+), 5 deletions(-)
>   create mode 100644 drivers/net/wireless/ath/ath11k/coredump.c
>   create mode 100644 drivers/net/wireless/ath/ath11k/coredump.h
> 
> 
> base-commit: 3fa9da4001890def44801dd56d5fbc134689be28



More information about the ath11k mailing list