[PATCH] wifi: ath11k: Add crash logging

Kalle Valo kvalo at kernel.org
Mon Jul 10 23:40:53 PDT 2023


Arowa Suliman <arowa at chromium.org> writes:

> Change crash logging from debug to informational and add warning when
> firmware crash MHI_CB_EE_RDDM happens.

Why? What's the reason why you want to change this? The commit log
should always describe that.

> Tested-on: Qualcomm WCN6855

This is not correct format:

https://wireless.wiki.kernel.org/en/users/drivers/ath11k/submittingpatches#tested-on_tag

> Reported-by: kernel test robot <lkp at intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202306141105.c1e82Q0y-lkp@intel.com/

The robot only reported problems with your patch, it didn't report the
original problem. So you should remove these two lines.

> Signed-off-by: Arowa Suliman <arowa at google.com>

>From and s-o-b have different email addresses.

Also this seems to a second version of your patch so you should have
marked it as v2 and include a changelog what changed from v1.

Please read our documentation from the wiki link below how to submit
patches.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



More information about the ath11k mailing list