[PATCH 04/15] mac80211: make channel context code MLO-aware

[Johannes Berg]

On Tue, 2023-02-14 at 16:09 +0800, Wen Gong wrote:
> On 2/14/2023 4:04 PM, Johannes Berg wrote:
> > On Tue, 2023-02-14 at 15:57 +0800, Wen Gong wrote:
> > > >    void rate_control_rate_update(struct ieee80211_local *local,
> > > > -				    struct ieee80211_supported_band *sband,
> > > > -				    struct sta_info *sta, u32 changed)
> > > > +			      struct ieee80211_supported_band *sband,
> > > > +			      struct sta_info *sta, unsigned int link_id,
> > > > +			      u32 changed)
> > > >    {
> > > >    	struct rate_control_ref *ref = local->rate_ctrl;
> > > >    	struct ieee80211_sta *ista = &sta->sta;
> > > >    	void *priv_sta = sta->rate_ctrl_priv;
> > > >    	struct ieee80211_chanctx_conf *chanctx_conf;
> > > >    
> > > > +	WARN_ON(link_id != 0);
> > > > +
> > > >    	if (ref && ref->ops->rate_update) {
> > > >    		rcu_read_lock();
> > > >    
> > > Why link_id must = 0 here?
> > > 
> > The whole software rate scaling hasn't been adjusted for MLO yet.
> 
> Got it. Thanks.
> 
> So I guess this WARN_ON will be change later.
> 

Since you're running into it, you should probably think about addressing
this ... I'm not going to, our hardware doesn't use this code.

johannes