[PATCH] wifi: mac80211: RCU-ify link STA pointers

Wen Gong quic_wgong at quicinc.com
Mon Sep 12 02:36:47 PDT 2022


Hi Johannes,

Currently for MLO test, the others links's rx_nss of struct
ieee80211_link_sta is still value 0 in ieee80211_set_associated(),
becaue they are not pass into ieee80211_sta_set_rx_nss() in
mac80211 except the deflink which means the primary link.
This lead driver get nss = 0 for other links. Will you fix it
or is it design by default?

Only primary link has valid rx_nss value which is not 0 by below call stack.
ieee80211_assoc_success()->
     rate_control_rate_init(sta);

commit:c71420db653aba30a234d1e4cf86dde376e604fa
wifi: mac80211: RCU-ify link STA pointers

diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c
index c58d9689f51f..7947e9a162a9 100644
--- a/net/mac80211/rate.c
+++ b/net/mac80211/rate.c
@@ -37,7 +37,7 @@ void rate_control_rate_init(struct sta_info *sta)
      struct ieee80211_supported_band *sband;
      struct ieee80211_chanctx_conf *chanctx_conf;

-    ieee80211_sta_set_rx_nss(sta, 0);
+    ieee80211_sta_set_rx_nss(&sta->deflink);

      if (!ref)
          return;





More information about the ath11k mailing list