[PATCH 01/15] mac80211: split bss_info_changed method

[Wen Gong]

On 10/18/2022 4:50 PM, Johannes Berg wrote:
> On Tue, 2022-10-18 at 16:47 +0800, Wen Gong wrote:
>>> +	if (changed & ~BSS_CHANGED_VIF_CFG_FLAGS) {
>>> +		/* FIXME: should be for each link */
>>> +		trace_drv_link_info_changed(local, sdata, 0, changed);
>>> +		if (local->ops->link_info_changed)
>>> +			local->ops->link_info_changed(&local->hw, &sdata->vif,
>>> +						      0, changed);
>> I think you/someone will change here later for the "/* FIXME: should be
>> for each link */", right?
> Maybe. I'm not actually sure it's really needed, it depends how we use
> this in the future.
>
>> It lead error/kernel crash as below while reconfig single MLO link which
>> link id is 2.
>> When test with single MLO link which link id is 0, not found
>> error/kernel crash.
> I'm not surprised, I just worked on fixing reconfig in the last few
> days, will post it after some more review/testing.
Thanks.
> So I think that might not need changes *here*, but rather a proper FW
> restart. Which I haven't tested in AP mode though -- was the crash in AP
> mode?
It is crash in station mode.
> johannes