QCA6390 power saving issue

[Mark Herbert]

I have tried modification proposed by Wi - but still same situation.

Also I've tried to go same direction and injected the call to the psmode 
enabling fuction in multiple places of the mac.c file. Enable debug mask 
for mac events - and I see that the code is called many times now. But 
still no effect - until the first connection to network happens no PC 
states more than PC3 are reached.


When first connect happens - all good till reboot or hibernate.


On 3/30/22 15:47, Kalle Valo wrote:
> + ath11k list
>
> Mark Herbert <mark.herbert42 at gmail.com> writes:
>
>> Done - https://bugzilla.kernel.org/show_bug.cgi?id=215775
> Thanks!
>
>> Checked the previous bug - the powersave activation is done only on
>> change of something - so when the driver is loaded but never connected
>> so this IF did not become true at least one time - the powersave is
>> not yet enabled and card remains in the initial setting keeping PC3 as
>> a lowest state. Seems that when we initialize the driver we need to
>> call this ath11k_mac_config_ps(ar) one time - then on each change of
>> the connection the current code will handle that.
>>
>> @@ -2942,6 +3019,16 @@ static void ath11k_mac_op_bss_info_changed(struct ieee80211_hw
>> *hw,
>> ath11k_mac_txpower_recalc(ar);
>> }
>> + if (changed & BSS_CHANGED_PS &&
>> + ar->ab->hw_params.supports_sta_ps) {
>> + arvif->ps = vif->bss_conf.ps;
>> +
>> + ret = ath11k_mac_config_ps(ar);
>> + if (ret)
>> + ath11k_warn(ar->ab, "failed to setup ps on vdev %i: %d\n",
>> + arvif->vdev_id, ret);
>> + }
> Didn't check the code, but makes sense. Can you or someone else send a
> patch, please?
>