[PATCH] ath11k: Handle keepalive during wowlan suspend and resume

[Baochen Qiang]

On 5/6/2022 3:04 AM, Jeff Johnson wrote:
> On 5/4/2022 6:46 PM, Baochen Qiang wrote:
>> With wowlan enabled and after sleeping for a rather long time,
>
> nit: s/wowlan/WoWLAN/ to conform to common usage (also in subject)
>
already fixed in v2.


>> we are seeing that with some APs, it is not able to wake up
>> the STA though the correct wake up pattern has been configured.
>> This is because the host doesn't send keepalive command to
>> firmware, thus firmware will not send any packet to the AP and
>> after a specific time the AP kicks out the DUT.
>>
>> Fix this issue by enabling keepalive before going to suspend
>> and disabling it after resume back.
>>
>> Tested-on: WCN6855 hw2.0 PCI 
>> WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
>>
>> Signed-off-by: Baochen Qiang <quic_bqiang at quicinc.com>
>> ---
>
> [...]
>
>> +
>> +enum wmi_sta_keepalive_method {
>> +    WMI_STA_KEEPALIVE_METHOD_NULL_FRAME = 1, /* 802.11 NULL frame */
>> +    WMI_STA_KEEPALIVE_METHOD_UNSOLICITED_ARP_RESPONSE = 2, /* ARP 
>> response */
>> +    WMI_STA_KEEPALIVE_METHOD_ETHERNET_LOOPBACK = 3, /*ETHERNET 
>> LOOPBACK*/
>> +    WMI_STA_KEEPALIVE_METHOD_GRATUITOUS_ARP_REQUEST = 4, /* 
>> gratuitous ARP req*/
>
> nit: for the two above consistently have space separating comment from 
> /* and */
>
sure, will address in v3.


>> + WMI_STA_KEEPALIVE_METHOD_MGMT_VENDOR_ACTION = 5, /* vendor action 
>> frame */
>> +};
> [...]