[bug report] ath11k: report rssi of each chain to mac80211 for QCA6390/WCN6855

[Dan Carpenter]

On Thu, May 05, 2022 at 06:32:48PM +0800, Wen Gong wrote:
> On 5/5/2022 6:25 PM, Dan Carpenter wrote:
> > Hello Wen Gong,
> > 
> > The patch b488c766442f: "ath11k: report rssi of each chain to
> > mac80211 for QCA6390/WCN6855" from Dec 17, 2021, leads to the
> > following Smatch static checker warning:
> > 
> > 	drivers/net/wireless/ath/ath11k/wmi.c:5800 ath11k_wmi_tlv_rssi_chain_parse()
> > 	warn: missing error code here? 'ieee80211_find_sta_by_ifaddr()' failed. 'ret' = '0'
> 
> yes, it should return 0.
> 
> please see this commit:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/drivers/net/wireless/ath/ath11k?id=7330e1ec9748948177830c6e1a13379835d577f9
> 
> ath11k: fix warning of not found station for bssid in message
> 

We could silence the warning and make the code more obvious by setting
the "ret = 0;" explicitly or another option would be to add a comment.

regards,
dan carpenter