[PATCH v6 2/2] ath11k: add read variant from SMBIOS for download board data

Kalle Valo kvalo at kernel.org
Wed Mar 23 01:47:46 PDT 2022


Wen Gong <quic_wgong at quicinc.com> writes:

> This is to read variant from SMBIOS such as read from DT, the variant
> string will be used to one part of string which used to search board
> data from board-2.bin.
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>
> Signed-off-by: Wen Gong <quic_wgong at quicinc.com>

[...]

> +struct ath11k_smbios_bdf {
> +	struct dmi_header hdr;
> +	u32 padding;
> +	u8 bdf_enabled;
> +	u8 bdf_ext[1];
> +};

I was about to commit this but noticed bdf_ext[1], is there a reason for
that? Use of [1] in arrays is deprecated nowadays:

https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



More information about the ath11k mailing list