[PATCH] ath11k: add read country code from SMBIOS for WCN6855/QCA6390
Kalle Valo
kvalo at kernel.org
Sat Apr 23 02:53:01 PDT 2022
Wen Gong <quic_wgong at quicinc.com> writes:
> This read the country code from SMBIOS and send the country code
> to firmware, firmware will indicate the regulatory domain info of the
> country code and then ath11k will use the info.
>
> dmesg:
> [ 1242.637173] ath11k_pci 0000:02:00.0: chip_id 0x2 chip_family 0xb board_id 0xff soc_id 0x400c0200
> [ 1242.637176] ath11k_pci 0000:02:00.0: fw_version 0x110b09e5 fw_build_timestamp 2021-06-22 09:32 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HSP.1.1-02533-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1
> [ 1242.637253] ath11k_pci 0000:02:00.0: worldwide regdomain setting from SMBIOS
> [ 1242.637259] ath11k_pci 0000:02:00.0: bdf variant name not found.
> [ 1242.637261] ath11k_pci 0000:02:00.0: SMBIOS bdf variant name not set.
> [ 1242.637263] ath11k_pci 0000:02:00.0: DT bdf variant name not set.
> [ 1242.927543] ath11k_pci 0000:02:00.0: set current country pdev id 0 alpha2 00
>
> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3
>
> Signed-off-by: Wen Gong <quic_wgong at quicinc.com>
[...]
> --- a/drivers/net/wireless/ath/ath11k/core.h
> +++ b/drivers/net/wireless/ath/ath11k/core.h
> @@ -169,12 +169,31 @@ struct ath11k_ext_irq_grp {
> struct net_device napi_ndev;
> };
>
> +enum ath11k_smbios_cc_type {
> + /* disable country code setting from SMBIOS */
> + ATH11K_SMBIOS_CC_DISABLE = 0,
> + /* set country code by ANSI country name, based on ISO3166-1 alpha2 */
> + ATH11K_SMBIOS_CC_ISO = 1,
> + /* worldwide regdomain */
> + ATH11K_SMBIOS_CC_WW = 2,
> +};
In the pending branch I did some whitespace cleanup in this and the
following struct.
> +
> struct ath11k_smbios_bdf {
> struct dmi_header hdr;
> - u32 padding;
> + u8 features_disabled;
> + /* enum ath11k_smbios_cc_type */
> + u8 country_code_flag;
> + /* To set specific country, you need to set country code
> + * flag=ATH11K_SMBIOS_CC_ISO first, then if country is United States, then country
> + * code value = 0x5553 ("US",'U' = 0x55, 'S'= 0x53), To set country
> + * to INDONESIA, then country code value = 0x4944 ("IN", 'I'=0x49, 'D'=0x44).
> + * If country code flag = ATH11K_SMBIOS_CC_WW, then you can use
> + * worldwide regulatory setting.
> + */
> + __le16 cc_code;
> u8 bdf_enabled;
> u8 bdf_ext[];
> -};
> +} __packed;
Is cc_code really in little endian? I would expect data in smbios to be
in native endian (ie. u16), bios using different endian than the host
sounds strange to me. And struct dmi_header also uses native endian:
struct dmi_header {
u8 type;
u8 length;
u16 handle;
} __packed;
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
More information about the ath11k
mailing list