[PATCH 4/4] ath11k: add caldata download support from EEPROM

[Kalle Valo]

Anilkumar Kolli <akolli at codeaurora.org> writes:

> On 2021-09-24 20:34, Kalle Valo wrote:
>> Jouni Malinen <jouni at codeaurora.org> writes:
>>
>>> From: Anilkumar Kolli <akolli at codeaurora.org>
>>>
>>> Firmware updates EEPROM support capability in QMI FW caps, send QMI
>>> BDF
>>> download request message with file type EEPROM, to get caldata
>>> download
>>> from EEPROM. Firmware takes more time to update cal data from
>>> EEPROM, so
>>> increase QMI timeout.
>>
>> The commit log would need more explanation how this patch works.
>>
>
> FW advertizes calibration data support from EEPROM through
> 'eeprom_read_timeout' in QMI FW Capability message. Ath11k sends BDF
> download request with file type 'ATH11K_QMI_FILE_TYPE_EEPROM'. FW has
> logic to read calibration data from EEPROM and process the calibration
> data. FW takes more time to process the calibration data from EEPROM
> so increase QMI timeout to 10msec.

Thanks, I now copied the updated commit log below. And do note that the
timeout is 10 s, not 10 ms.

    ath11k: add caldata download support from EEPROM
    
    In some devices the calibration data is stored to EEPROM within the device so add
    support for that.
    
    The firmware advertises the calibration data support from EEPROM through
    'eeprom_read_timeout' in the QMI firmware capability message. ath11k sends
    boardfile download request with file type 'ATH11K_QMI_FILE_TYPE_EEPROM'. The
    firmware has logic to read calibration data from EEPROM and process the
    calibration data.
    
    As now the firmware takes more time to process the calibration data from EEPROM
    so increase QMI timeout to 10 seconds.
    
    Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01838-QCAHKSWPL_SILICONZ-1


-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches