Can not unload ath11k_pci and load it back

[Mark Herbert]

Applied several patches series from latest mailing list

ath11k: add feature for device recovery (3 pathes)

ath11k: support for WoW functionalities (6 patches)

ath11k: Advertise PLATFORM CAP PCIE GLOBAL RESET.


Before those the system was deadly stuck on resume from hibernation - 
but now it gives control back, so I can see the error log in DMESG.  The 
card is not waiking up , and I still can not unload/reload the 
ath11k_pci module to get device back. But here is the log  - maybe it 
will give some ideas.


[137698.301974] ACPI: EC: interrupt unblocked
[137698.498119] usb usb1: root hub lost power or was reset
[137698.498122] usb usb2: root hub lost power or was reset
[137698.498186] usb usb3: root hub lost power or was reset
[137698.498195] usb usb4: root hub lost power or was reset
[137698.498231] ath11k_pci 0000:72:00.0: failed to set mhi state: RESUME(6)
[137698.522871] nvme nvme0: 7/0/0 default/read/poll queues
[137698.656843] i915 0000:00:02.0: [drm] GuC firmware 
i915/tgl_guc_62.0.0.bin version 62.0 submission:disabled
[137698.656849] i915 0000:00:02.0: [drm] GuC SLPC: disabled
[137698.656850] i915 0000:00:02.0: [drm] HuC firmware 
i915/tgl_huc_7.9.3.bin version 7.9 authenticated:yes
[137698.848725] usb 3-6: reset high-speed USB device number 3 using xhci_hcd
[137699.042347] usb 3-6: restoring control 
00000000-0000-0000-0000-000000000101/10/5
[137699.042356] usb 3-6: restoring control 
00000000-0000-0000-0000-000000000101/12/11
[137699.178934] usb 3-3: reset full-speed USB device number 2 using xhci_hcd
[137701.548589] ath11k_pci 0000:72:00.0: timed out while waiting for wow 
wakeup completion
[137701.548596] ath11k_pci 0000:72:00.0: failed to wakeup wow during 
resume: -110
[137701.548599] ath11k_pci 0000:72:00.0: failed to resume core: -110
[137701.548601] PM: dpm_run_callback(): pci_pm_restore+0x0/0xd0 returns -110
[137701.548621] ath11k_pci 0000:72:00.0: PM: failed to restore async: 
error -110
[137701.557110] PM: hibernation: Basic memory bitmaps freed
[137701.557113] OOM killer enabled.
[137701.557115] Restarting tasks ... done.
[137701.619948] PM: hibernation: hibernation exit
[137701.624409] usbcore: registered new interface driver btusb
[137704.668739] ath11k_pci 0000:72:00.0: wmi command 16387 timeout
[137704.668781] ath11k_pci 0000:72:00.0: failed to send 
WMI_PDEV_SET_PARAM cmd
[137704.668795] ath11k_pci 0000:72:00.0: failed to enable PMF QOS: (-11


On 07.10.2021 10:48, Kalle Valo wrote:
> Mark Herbert <mark.herbert42 at gmail.com> writes:
>
>> I've found similar bug files already - so not to create duplicates
>> simply commented there
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=214541
>>
>> Exactly - hibernation means saving state on disk and resuming later,
>> it is a very usefull feature when you are running out of battery and
>> want to save your work.
> Got it, thanks. So it seems we have two issues here: ath11k does not
> support hibernation and ath11k module reload failing. Let's handle the
> module reload failing in bug #214541, but can you file another bug about
> the missing support for hibernation? Let's have one issue per bug
> report, it's easier to manage bugzilla that way.
>
>> Also one more point I've found - if MHI is configured in the kernel -
>> the card is starting up on thr first boot and works. But if i
>> configure MHI as a module - it does not. MHI module do load. So do
>> ath11k and ath11k_pci.  But the last ath11k dmesg says :
>>
>> mhi mhi0: Wait for device to enter SBL or Mission mode
>>
>> Exactly as if I  do rmmod/modprobe sequence.
>>
>> I use latest BIOS from Dell (in fact upgrading 3.0.4 to 3.1.0 did not
>> cange anythng) ,  and have tried multiple kernels. Stable 5.14 series
>> and ath11k git tree (next and master-pending). Nothing helps.
>> Sometimes it woks out - I had couple of times successfully
>> rmmod/modprobe ath11k_pci but it s a kind of random and very rare
>> event ( I had it 2 times only).
>>
>> So for me it looks like an issue between MHI and ath11k , but
>> ubfortunately my knowledge is not enough to propose any solution here.
> On my NUC x86 test box I reload ath11k modules several times a day while
> I test ath11k but I always reload the mhi modules at the same time,
> maybe that makes the difference? Or XPS 13 9310 works differently from
> NUC, that's also possible.
>