[PATCH 3/3] ath11k: add synchronization operation between reconfigure of mac80211 and ath11k_base
kernel test robot
lkp at intel.com
Mon Oct 11 04:59:37 PDT 2021
Hi Wen,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kvalo-ath/ath-next]
[also build test WARNING on v5.15-rc5 next-20211011]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Wen-Gong/ath11k-add-feature-for-device-recovery/20211011-162222
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath-next
config: ia64-randconfig-r012-20211011 (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/a741690b3c6676fe11f42d6e9740b5d6f5fb91fa
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Wen-Gong/ath11k-add-feature-for-device-recovery/20211011-162222
git checkout a741690b3c6676fe11f42d6e9740b5d6f5fb91fa
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All warnings (new ones prefixed by >>):
drivers/net/wireless/ath/ath11k/mac.c: In function 'ath11k_mac_wait_reconfigure':
>> drivers/net/wireless/ath/ath11k/mac.c:5187:14: warning: variable 'time_left' set but not used [-Wunused-but-set-variable]
5187 | long time_left;
| ^~~~~~~~~
vim +/time_left +5187 drivers/net/wireless/ath/ath11k/mac.c
5184
5185 static void ath11k_mac_wait_reconfigure(struct ath11k_base *ab)
5186 {
> 5187 long time_left;
5188 int recovery_start_count;
5189
5190 if (!ab->is_reset)
5191 return;
5192
5193 recovery_start_count = atomic_inc_return(&ab->recovery_start_count);
5194 ath11k_dbg(ab, ATH11K_DBG_MAC, "recovery start count %d\n", recovery_start_count);
5195
5196 if (recovery_start_count == ab->num_radios) {
5197 complete(&ab->recovery_start);
5198 ath11k_dbg(ab, ATH11K_DBG_MAC, "recovery started success\n");
5199 }
5200
5201 ath11k_dbg(ab, ATH11K_DBG_MAC, "waiting reconfigure...\n");
5202
5203 time_left = wait_for_completion_timeout(&ab->reconfigure_complete,
5204 ATH11K_RECONFIGURE_TIMEOUT_HZ);
5205 }
5206
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 33893 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/ath11k/attachments/20211011/9485ffc5/attachment-0001.gz>
More information about the ath11k
mailing list