[PATCH v3 0/3] ath11k: add feature for device recovery

[Wen Gong]

On 2021-11-15 20:53, Kalle Valo wrote:
> Wen Gong <wgong at codeaurora.org> writes:
> 
>> From: Wen Gong <quic_wgong at quicinc.com>
>> 
>> v3: remove time_left set but not used in
>>     "ath11k: add synchronization operation between reconfigure of 
>> mac80211 and ath11k_base"
>> 
>> v2: s/initilized/initialized in commit log of patch
>>     "ath11k: add synchronization operation between reconfigure of 
>> mac80211 and ath11k_base"
>> 
>> Add support for device recovery.
>> 
>> Wen Gong (3):
>>   ath11k: add ath11k_qmi_free_resource() for recovery
>>   ath11k: add support for device recovery for QCA6390
>>   ath11k: add synchronization operation between reconfigure of 
>> mac80211
>>     and ath11k_base
> 
> I did some quick testing (commit 4716d5bb1e16 in pending branch) and it
> does not seem to work for me:
> 
> oot at nuc1:~# echo assert > /sys/kernel/debug/ath11k/qca6390\
> hw2.0/simulate_fw_crash
> root at nuc1:~# iw wlan0 scan
> command failed: Connection timed out (-110)
> root at nuc1:~#
> 
> Kernel logs have:
> 
> [  118.903092] ath11k_pci 0000:06:00.0: BAR 0: assigned [mem
> 0xdb000000-0xdbffffff 64bit]
> [  118.925164] ath11k_pci 0000:06:00.0: MSI vectors: 32
> [  118.925285] ath11k_pci 0000:06:00.0: qca6390 hw2.0
> [  119.093214] mhi mhi0: Requested to power ON
> [  119.095430] mhi mhi0: Power on setup success
> [  119.423735] mhi mhi0: Wait for device to enter SBL or Mission mode
> [  119.543030] ath11k_pci 0000:06:00.0: chip_id 0x0 chip_family 0xb
> board_id 0xff soc_id 0xffffffff
> [  119.543197] ath11k_pci 0000:06:00.0: fw_version 0x101c06cc
> fw_build_timestamp 2020-06-24 19:50 fw_build_id
> [  230.101077] ip (2367) used greatest stack depth: 24384 bytes left
> [  283.663895] ath11k_pci 0000:06:00.0: simulating firmware assert 
> crash
> [  283.738422] ath11k_pci 0000:06:00.0: firmware crashed: 
> MHI_CB_SYS_ERROR
> [  295.236831] ath11k_pci 0000:06:00.0: wmi command 12290 timeout
> [  295.237937] ath11k_pci 0000:06:00.0: failed to send 
> WMI_STOP_SCAN_CMDID
> [  295.238467] ath11k_pci 0000:06:00.0: failed to stop wmi scan: -11
> [  295.240049] ath11k_pci 0000:06:00.0: failed to stop scan: -11
> [  295.240558] ath11k_pci 0000:06:00.0: failed to start hw scan: -110
> 

I have sent v4, it is not to fix your fail:)
It added patch "ath11k: fix invalid m3 buffer address".
https://patchwork.kernel.org/project/linux-wireless/cover/20211116041522.23529-1-quic_wgong@quicinc.com/


> Also there should be a clear ath11k_warn() message when firmware
> recovery was successful, I could not find one from patches.

Yes, if recovery succes, it will have "success" log.