[PATCH v7 1/3] ath11k: switch to using ieee80211_tx_status_ext()

Pradeep Kumar Chitrapu pradeepc at codeaurora.org
Thu Mar 18 20:24:44 GMT 2021


>> +	spin_lock_bh(&ab->base_lock);
>> +	peer = ath11k_peer_find_by_id(ab, ts->peer_id);
>> +	if (peer) {
>> +		arsta = (struct ath11k_sta *)peer->sta->drv_priv;
>> +		status.sta = peer->sta;
>> +		status.skb = msdu;
>> +		status.info = info;
>> +		status.rate = &arsta->last_txrate;
>> +	}
>> +	rcu_read_unlock();
>> +	if (peer)
>> +		ieee80211_tx_status_ext(ar->hw, &status);
>> +	else
>> +		dev_kfree_skb_any(msdu);
>> +	spin_unlock_bh(&ab->base_lock);
> 
> Why ieee80211_tx_status_ext() kept under spin_lock?
> 
> Thanks,
> Karthikeyan P
Thanks Karthikeyan for the review..Yes, spin lock could be avoided for
ieee80211_tx_status_ext(). I will address this in next revision.

Thanks
pradeep



More information about the ath11k mailing list