[bug report] ath11k: Add qcn9074 mhi controller config
Dan Carpenter
dan.carpenter at oracle.com
Thu Mar 18 13:13:31 GMT 2021
Hello Anilkumar Kolli,
The patch a233811ef600: "ath11k: Add qcn9074 mhi controller config"
from Feb 16, 2021, leads to the following static checker warning:
drivers/net/wireless/ath/ath11k/mhi.c:357 ath11k_mhi_register()
error: uninitialized symbol 'ath11k_mhi_config'.
drivers/net/wireless/ath/ath11k/mhi.c
342 mhi_ctrl->iova_stop = 0xffffffff;
343 mhi_ctrl->sbl_size = SZ_512K;
344 mhi_ctrl->seg_len = SZ_512K;
345 mhi_ctrl->fbc_download = true;
346 mhi_ctrl->runtime_get = ath11k_mhi_op_runtime_get;
347 mhi_ctrl->runtime_put = ath11k_mhi_op_runtime_put;
348 mhi_ctrl->status_cb = ath11k_mhi_op_status_cb;
349 mhi_ctrl->read_reg = ath11k_mhi_op_read_reg;
350 mhi_ctrl->write_reg = ath11k_mhi_op_write_reg;
351
352 if (ab->hw_rev == ATH11K_HW_QCA6390_HW20)
353 ath11k_mhi_config = &ath11k_mhi_config_qca6390;
354 else if (ab->hw_rev == ATH11K_HW_QCN9074_HW10)
355 ath11k_mhi_config = &ath11k_mhi_config_qcn9074;
ath11k_mhi_config not initialized for other revs. Which seem to exist
so this seems like it could be a real bug?
356
357 ret = mhi_register_controller(mhi_ctrl, ath11k_mhi_config);
358 if (ret) {
359 ath11k_err(ab, "failed to register to mhi bus, err = %d\n", ret);
360 mhi_free_controller(mhi_ctrl);
361 return ret;
362 }
363
364 return 0;
365 }
regards,
dan carpenter
More information about the ath11k
mailing list