[PATCH v2 1/8] cfg80211: add power type definition for 6 GHz

[Wen Gong]

On 2021-08-26 16:20, Johannes Berg wrote:
>>  struct cfg80211_chan_def {
>>  	struct ieee80211_channel *chan;
>> @@ -684,6 +685,7 @@ struct cfg80211_chan_def {
>>  	u32 center_freq2;
>>  	struct ieee80211_edmg edmg;
>>  	u16 freq1_offset;
>> +	enum nl80211_ap_reg_power power_type;
> 
> I'm not sure why this should be in the chandef, there's no way that
> anything in cfg80211 is ever using it there, at least in your patches.
> 
It is used in mac80211 of [PATCH v2 3/8] mac80211: add parse regulatory 
info in 6 GHz operation information.
should i move it to mac80211's .h file?
>> +/**
>> + * enum nl80211_ap_reg_power - regulatory power for a Access Point
>> + *
>> + * @NL80211_REG_UNSET_AP: Access Point has no regulatory power mode
>> + * @NL80211_REG_LPI: Indoor Access Point
>> + * @NL80211_REG_SP: Standard power Access Point
>> + * @NL80211_REG_VLP: Very low power Access Point
>> + */
>> +enum nl80211_ap_reg_power {
>> +	NL80211_REG_UNSET_AP,
>> +	NL80211_REG_LPI_AP,
>> +	NL80211_REG_SP_AP,
>> +	NL80211_REG_VLP_AP,
>> +	NL80211_REG_AP_POWER_AFTER_LAST,
>> +	NL80211_REG_AP_POWER_MAX =
>> +		NL80211_REG_AP_POWER_AFTER_LAST - 1,
>> +};
> 
> Similarly here (and the other enum), why is this in nl80211 if it's
> never used in nl80211?
> 
It is used in mac80211 of [PATCH v2 3/8] mac80211: add parse regulatory 
info in 6 GHz operation information.
should i move it to mac80211's .h file?
> johannes