ath11k: Country code setting ignored on bootup

[Sriram R]

On 2020-11-04 22:00, Sven Eckelmann wrote:
> On Wednesday, 4 November 2020 17:25:53 CET Sriram R wrote:
>> btw, i dont see any possible issues in current usage of
>> ATH11k_FLAG_REGISTERED in
>>   ath11k_debug_pdev_create, ath11k_mac_register and 
>> ath11k_mac_allocate
>> since they sequenced and fall within the same context. Do you face any
>> issues?
> 
> A firmware crash before ATH11K_QMI_EVENT_FW_READY was 
> processed/received. So
> we might want to recreate the mac/debugfs/... even when it was already 
> created
> - at least this is the stuff mentioned in the commit(s) which introduce 
> the
> ATH11k_FLAG_REGISTERED in these positions.
Yeah right, i think it was added to avoid multiple driver registration.
The ATH11K_FLAG_REGISTERED currently implies core registration complete 
where
mac registration is one part of it. Agree that checking this flag in reg 
path
is not the right approach to decide if mac is registered and default 
rules are
applied for it.
I can also prepare a patch to avoid the issue you had mentioned and a
similar race as below (which i noted with this patch in my setup)and
see if it works fine for all use cases.
Please note below on the 4th line, the Default regd for pdev 0 gets
overwritten from US to IN(the country set before ath11k bind), which is 
not desirable.

[  949.056244] ath11k c000000.wifi1: Default REGD update pdev 0 US
[  949.056493] ath11k c000000.wifi1: Default REGD update pdev 1 US
[  949.056595] ath11k c000000.wifi1: Default REGD update pdev 2 US
[  949.061231] ath11k c000000.wifi1: Default REGD update pdev 0 IN
[  949.063915] ath11k c000000.wifi1: User REGD update pdev 1 IN
[  949.066156] ath11k c000000.wifi1: User REGD update pdev 2 IN

Thanks and Regards,
Sriram.R
> 
> Kind regards,
> 	Sven