[PATCH] mac80211: do intersection with he mcs and nss set of peer and own

[kernel test robot]

Hi Wen,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on mac80211-next/master]
[also build test WARNING on mac80211/master v5.10 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Wen-Gong/mac80211-do-intersection-with-he-mcs-and-nss-set-of-peer-and-own/20201222-103106
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: nds32-randconfig-p002-20201222 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/68bea73c7cc3c3640743b1ea62940dd03fcee14f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Wen-Gong/mac80211-do-intersection-with-he-mcs-and-nss-set-of-peer-and-own/20201222-103106
        git checkout 68bea73c7cc3c3640743b1ea62940dd03fcee14f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

>> net/mac80211/he.c:56:1: warning: no previous prototype for 'ieee80211_he_mcs_disable' [-Wmissing-prototypes]
      56 | ieee80211_he_mcs_disable(u16 *he_mcs)
         | ^~~~~~~~~~~~~~~~~~~~~~~~
>> net/mac80211/he.c:65:1: warning: no previous prototype for 'ieee80211_he_mcs_intersection' [-Wmissing-prototypes]
      65 | ieee80211_he_mcs_intersection(u16 *he_own_rx, u16 *he_peer_rx,
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/ieee80211_he_mcs_disable +56 net/mac80211/he.c

    54	
    55	void
  > 56	ieee80211_he_mcs_disable(u16 *he_mcs)
    57	{
    58		u32 i;
    59	
    60		for (i = 0; i < 8; i++)
    61			*he_mcs |= cpu_to_le16(IEEE80211_HE_MCS_NOT_SUPPORTED << i * 2);
    62	}
    63	
    64	void
  > 65	ieee80211_he_mcs_intersection(u16 *he_own_rx, u16 *he_peer_rx,
    66				      u16 *he_own_tx, u16 *he_peer_tx)
    67	{
    68		u32 i;
    69		u16 own_rx, own_tx, peer_rx, peer_tx;
    70	
    71		for (i = 0; i < 8; i++) {
    72			own_rx = le16_to_cpu(*he_own_rx);
    73			own_rx = (own_rx >> i * 2) & IEEE80211_HE_MCS_NOT_SUPPORTED;
    74	
    75			own_tx = le16_to_cpu(*he_own_tx);
    76			own_tx = (own_tx >> i * 2) & IEEE80211_HE_MCS_NOT_SUPPORTED;
    77	
    78			peer_rx = le16_to_cpu(*he_peer_rx);
    79			peer_rx = (peer_rx >> i * 2) & IEEE80211_HE_MCS_NOT_SUPPORTED;
    80	
    81			peer_tx = le16_to_cpu(*he_peer_tx);
    82			peer_tx = (peer_tx >> i * 2) & IEEE80211_HE_MCS_NOT_SUPPORTED;
    83	
    84			if (peer_tx != IEEE80211_HE_MCS_NOT_SUPPORTED) {
    85				if (own_rx == IEEE80211_HE_MCS_NOT_SUPPORTED)
    86					peer_tx = IEEE80211_HE_MCS_NOT_SUPPORTED;
    87				else if (own_rx < peer_tx)
    88					peer_tx = own_rx;
    89			}
    90	
    91			if (peer_rx != IEEE80211_HE_MCS_NOT_SUPPORTED) {
    92				if (own_tx == IEEE80211_HE_MCS_NOT_SUPPORTED)
    93					peer_rx = IEEE80211_HE_MCS_NOT_SUPPORTED;
    94				else if (own_tx < peer_rx)
    95					peer_rx = own_tx;
    96			}
    97	
    98			*he_peer_rx &=
    99				~cpu_to_le16(IEEE80211_HE_MCS_NOT_SUPPORTED << i * 2);
   100			*he_peer_rx |= cpu_to_le16(peer_rx << i * 2);
   101	
   102			*he_peer_tx &=
   103				~cpu_to_le16(IEEE80211_HE_MCS_NOT_SUPPORTED << i * 2);
   104			*he_peer_tx |= cpu_to_le16(peer_tx << i * 2);
   105		}
   106	}
   107	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 36273 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/ath11k/attachments/20201224/c2b5a277/attachment-0001.gz>