[PATCH V5 4/5] mac80211: add support for BSS coloring

Johannes Berg johannes at sipsolutions.net
Thu Aug 27 08:26:18 EDT 2020


> + * @color_change_active: marks whether a color change is going on. Internally it is
> + *	write-protected by sdata_lock and local->mtx so holding either is fine
> + *	for read access.
> 

I started fixing up things like that but then I got annoyed and gave up
...

Just because checkpatch no longer warns on >80 columns that doesn't mean
it's suddenly completely acceptable to write very long lines. In flowed
text like this, it's much nicer to have shorter lines, and long lines
are just arbitrary.

That's actually in quite a few places in this patch - comments, function
arguments, etc.

Nothing against going over 80 where that makes the code more readable,
but long lines for flowed text are *less* readable.

johannes




More information about the ath11k mailing list