[PATCH V5 3/5] nl80211: add support for BSS coloring

Johannes Berg johannes at sipsolutions.net
Thu Aug 27 08:24:45 EDT 2020


> +	if (info->attrs[NL80211_ATTR_CNTDWN_OFFS_PRESP]) {
> +		params.counter_offset_presp =
> +			nla_get_u16(info->attrs[NL80211_ATTR_CNTDWN_OFFS_PRESP]);

You need to check the attribute size here, apparently only exactly a
single counter is supported.

I'm not really sure *why* though - wouldn't be that much more difficult
to add support for an arbitrary number in mac80211?

Either way this is missing a check.

johannes





More information about the ath11k mailing list