[PATCH] [v2] wifi: ath10k: consistently use kstrtoX_from_user() functions

Jeff Johnson quic_jjohnson at quicinc.com
Wed Sep 20 12:20:08 PDT 2023

On 9/20/2023 8:39 AM, Dmitry Antipov wrote:
> Use 'kstrtoul_from_user()', 'kstrtobool_from_user()' and
> 'kstrtoint_from_user()' where appropriate and thus avoid
> some code duplication.
> Signed-off-by: Dmitry Antipov <dmantipov at yandex.ru>


> +	ssize_t ret;

curious why you changed this, especially given that you were bitten by 
the format change required. I would have left this as int and just let 
it promote to size_t or ssize_t as needed.

That said:
Acked-by: Jeff Johnson <quic_jjohnson at quicinc.com>

 > Hopefully this doesn't violate "if it isn't broke, don't fix
 > it" rule (the same thing was recently accepted for ath9k).

Patches that are very self-contained are more likely to be reviewed and 
accepted. But the maintainers don't have infinite bandwidth...


More information about the ath10k mailing list