[PATCH] net: Explicitly include correct DT includes

Wei Fang wei.fang at nxp.com
Sun Jul 16 18:47:00 PDT 2023

> -----Original Message-----
> From: Rob Herring <robh at kernel.org>
> Sent: 2023年7月15日 1:48
> To: Dario Binacchi <dario.binacchi at amarulasolutions.com>; Wolfgang
> Grandegger <wg at grandegger.com>; Marc Kleine-Budde
> <mkl at pengutronix.de>; David S. Miller <davem at davemloft.net>; Eric
> Dumazet <edumazet at google.com>; Jakub Kicinski <kuba at kernel.org>; Paolo
> Abeni <pabeni at redhat.com>; Chandrasekar Ramakrishnan
> <rcsekar at samsung.com>; Chen-Yu Tsai <wens at csie.org>; Jernej Skrabec
> <jernej.skrabec at gmail.com>; Samuel Holland <samuel at sholland.org>; Florian
> Fainelli <florian.fainelli at broadcom.com>; Andrew Lunn <andrew at lunn.ch>;
> Vladimir Oltean <olteanv at gmail.com>; Kurt Kanzenbach <kurt at linutronix.de>;
> Woojung Huh <woojung.huh at microchip.com>;
> UNGLinuxDriver at microchip.com; Arınç ÜNAL <arinc.unal at arinc9.com>;
> Daniel Golle <daniel at makrotopia.org>; Landen Chao
> <Landen.Chao at mediatek.com>; DENG Qingfang <dqfext at gmail.com>; Sean
> Wang <sean.wang at mediatek.com>; Matthias Brugger
> <matthias.bgg at gmail.com>; AngeloGioacchino Del Regno
> <angelogioacchino.delregno at collabora.com>; Claudiu Manoil
> <claudiu.manoil at nxp.com>; Alexandre Belloni
> <alexandre.belloni at bootlin.com>; Linus Walleij <linus.walleij at linaro.org>;
> Alvin Šipraga <alsi at bang-olufsen.dk>; George McCollister
> <george.mccollister at gmail.com>; Andreas Larsson <andreas at gaisler.com>;
> Iyappan Subramanian <iyappan at os.amperecomputing.com>; Keyur Chudgar
> <keyur at os.amperecomputing.com>; Chris Snook <chris.snook at gmail.com>;
> Nicolas Ferre <nicolas.ferre at microchip.com>; Claudiu Beznea
> <claudiu.beznea at microchip.com>; Madalin Bucur <madalin.bucur at nxp.com>;
> Wei Fang <wei.fang at nxp.com>; Shenwei Wang <shenwei.wang at nxp.com>;
> Clark Wang <xiaoning.wang at nxp.com>; dl-linux-imx <linux-imx at nxp.com>;
> Sean Anderson <sean.anderson at seco.com>; Pantelis Antoniou
> <pantelis.antoniou at gmail.com>; Leo Li <leoyang.li at nxp.com>; Yisen Zhuang
> <yisen.zhuang at huawei.com>; Salil Mehta <salil.mehta at huawei.com>;
> Douglas Miller <dougmill at linux.ibm.com>; Marcin Wojtas
> <mw at semihalf.com>; Russell King <linux at armlinux.org.uk>; Tara s Chornyi
> <taras.chornyi at plvision.eu>; Mirko Lindner <mlindner at marvell.com>;
> Stephen Hemminger <stephen at networkplumber.org>; Felix Fietkau
> <nbd at nbd.name>; John Crispin <john at phrozen.org>; Mark Lee
> <Mark-MC.Lee at mediatek.com>; Lorenzo Bianconi <lorenzo at kernel.org>;
> Horatiu Vultur <horatiu.vultur at microchip.com>; Timur Tabi
> <timur at kernel.org>; Sergey Shtylyov <s.shtylyov at omp.ru>; Steve Glendinning
> <steve.glendinning at shawell.net>; Kunihiko Hayashi
> <hayashi.kunihiko at socionext.com>; Giuseppe Cavallaro
> <peppe.cavallaro at st.com>; Alexandre Torgue <alexandre.torgue at foss.st.com>;
> Jose Abreu <joabreu at synopsys.com>; Maxime Coquelin
> <mcoquelin.stm32 at gmail.com>; Shawn Guo <shawnguo at kernel.org>; Sascha
> Hauer <s.hauer at pengutronix.de>; Pengutronix Kernel Team
> <kernel at pengutronix.de>; Fabio Estevam <festevam at gmail.com>; Neil
> Armstrong <neil.armstrong at linaro.org>; Kevin Hilman
> <khilman at baylibre.com>; Jerome Brunet <jbrunet at baylibre.com>; Martin
> Blumenstingl <martin.blumenstingl at googlemail.com>; Vinod Ko ul
> <vkoul at kernel.org>; Bhupesh Sharma <bhupesh.sharma at linaro.org>; Emil
> Renner Berthing <kernel at esmil.dk>; Samin Guo
> <samin.guo at starfivetech.com>; Thierry Reding <thierry.reding at gmail.com>;
> Jonathan Hunter <jonathanh at nvidia.com>; Nobuhiro Iwamatsu
> <nobuhiro1.iwamatsu at toshiba.co.jp>; Grygorii Strashko
> <grygorii.strashko at ti.com>; Kevin Brace
> <kevinbrace at bracecomputerlab.com>; Francois Romieu
> <romieu at fr.zoreil.com>; Michal Simek <michal.simek at amd.com>; Radhey
> Shyam Pandey <radhey.shyam.pandey at amd.com>; Alexander Aring
> <alex.aring at gmail.com>; Stefan Schmidt <stefan at datenfreihafen.org>;
> Miquel Raynal <miquel.raynal at bootlin.com>; Alex Elder <elder at kernel.org>;
> Clément Léger <clement.leger at bootlin.com>; Heiner Kallweit
> <hkallweit1 at gmail.com>; SkyLake Huang <SkyLake.Huang at mediatek.com>;
> Kalle Valo <kvalo at kernel.org>; Loic Poulain <loic.poulain at linaro.org>; Ryder
> Lee <ryder.lee at mediatek.com>; Shayne Chen <shayne.chen at mediatek.com>;
> Jérôme Pouille r <jerome.pouiller at silabs.com>; Richard Cochran
> <richardcochran at gmail.com>
> Cc: devicetree at vger.kernel.org; linux-can at vger.kernel.org;
> netdev at vger.kernel.org; linux-kernel at vger.kernel.org;
> linux-arm-kernel at lists.infradead.org; linux-sunxi at lists.linux.dev;
> linux-mediatek at lists.infradead.org; linuxppc-dev at lists.ozlabs.org;
> linux-renesas-soc at vger.kernel.org;
> linux-stm32 at st-md-mailman.stormreply.com;
> linux-amlogic at lists.infradead.org; linux-oxnas at groups.io;
> linux-tegra at vger.kernel.org; linux-omap at vger.kernel.org;
> linux-wpan at vger.kernel.org; ath10k at lists.infradead.org;
> linux-wireless at vger.kernel.org; ath11k at lists.infradead.org;
> wcn36xx at lists.infradead.org
> Subject: [PATCH] net: Explicitly include correct DT includes
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h and of.h.
> As a result, there's a pretty much random mix of those include files used
> throughout the tree. In order to detangle these headers and replace the
> implicit includes with struct declarations, users need to explicitly include the
> correct includes.
> Signed-off-by: Rob Herring <robh at kernel.org>
> ---
> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> b/drivers/net/ethernet/freescale/fec_ptp.c
> index ab86bb8562ef..9428a06b6a87 100644
> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> @@ -30,7 +30,6 @@
>  #include <linux/phy.h>
>  #include <linux/fec.h>
>  #include <linux/of.h>
> -#include <linux/of_device.h>
>  #include <linux/of_gpio.h>
>  #include <linux/of_net.h>
Reviewed-by: Wei Fang <wei.fang at nxp.com>

More information about the ath10k mailing list