[PATCH 1/2] wifi: cfg80211: Add beacon hint notifier support

[Johannes Berg]

> +++ b/include/net/cfg80211.h
> @@ -5386,6 +5386,8 @@ struct wiphy {
>  	void (*reg_notifier)(struct wiphy *wiphy,
>  			     struct regulatory_request *request);
>  
> +	void (*beacon_hint_notifier)(struct wiphy *wiphy);


missing documentation, for sure

Also this should probably be in the ops, rather than here? Not sure why
reg_notifier is here.

> -	if (channel_changed)
> +	if (channel_changed) {
>  		nl80211_send_beacon_hint_event(wiphy, &chan_before, chan);
> +		if (wiphy->beacon_hint_notifier)
> +			wiphy->beacon_hint_notifier(wiphy);
> +	}

This also seems excessive if you're not even passing the channel - you
call it for every (affected) channel, but you don't tell it anything
about the channel? Seems strange.


However ...

Why is this even needed? You should always get reg_notifier after this
anyway?

johannes