[PATCH] [v2] wifi: ath10k: cleanup CE initialization

Jeff Johnson quic_jjohnson at quicinc.com
Wed Aug 23 07:53:11 PDT 2023

On 8/23/2023 2:50 AM, Dmitry Antipov wrote:
> Commit 25d0dbcbd5c7 ("ath10k: split ce initialization and allocation")
> changes 'ath10k_ce_init_src_ring()' and 'ath10k_ce_init_dest_ring()'
> so these functions can't return -ENOMEM but always returns 0. This way
> both of the above may be converted to 'void' and related code may be
> simplified as well.
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> Signed-off-by: Dmitry Antipov <dmantipov at yandex.ru>

IMO you are doing too many changes in a single patch which makes it 
difficult to quickly review. Please keep it simple. Suggest you change a 
single function signature per patch. Any related code simplification 
should be in a separate patch.


More information about the ath10k mailing list