[PATCH] wireless: remove unneeded break

Christian Lamparter chunkeey at gmail.com
Mon Oct 19 11:14:31 EDT 2020


On 19/10/2020 17:05, trix at redhat.com wrote:
> From: Tom Rix <trix at redhat.com>
> 
> A break is not needed if it is preceded by a return or goto
> 
> Signed-off-by: Tom Rix <trix at redhat.com>

> diff --git a/drivers/net/wireless/intersil/p54/eeprom.c b/drivers/net/wireless/intersil/p54/eeprom.c
> index 5bd35c147e19..3ca9d26df174 100644
> --- a/drivers/net/wireless/intersil/p54/eeprom.c
> +++ b/drivers/net/wireless/intersil/p54/eeprom.c
> @@ -870,7 +870,6 @@ int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
>   			} else {
>   				goto good_eeprom;
>   			}
> -			break;
Won't the compiler (gcc) now complain about a missing fallthrough annotation?
>   		default:
>   			break;
>   		}

Cheers,
Christian



More information about the ath10k mailing list