[PATCH 1/6] relay: allow the use of const callback structs

Jani Nikula jani.nikula at intel.com
Mon Nov 23 13:01:17 EST 2020

On Thu, 19 Nov 2020, Christoph Hellwig <hch at infradead.org> wrote:
> But taking one step back:  All instances implement create_buf_file
> and remove_buf_file, which makes sense as that is the prime aim
> of these methods.  So there is no point in making those optional.
> subbuf_start_callback is overriden by two instances, so making that
> optional totally makes sense.  buf_mapped and buf_unmapped are
> never overriden, so they should be removed entirely.
> More importantly there is no case that passes a NULL rchan_callbacks,
> which makes complete sense as it wouldn't even create a file.  So
> remove that case as well and just replace it with a sanity check in
> relay_open().

Many thanks for the feedback; sent v2 [1].


[1] http://lore.kernel.org/r/cover.1606153547.git.jani.nikula@intel.com

Jani Nikula, Intel Open Source Graphics Center

More information about the ath10k mailing list