[PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE

Taehee Yoo ap420073 at gmail.com
Sat Nov 7 13:16:37 EST 2020

On Sun, 8 Nov 2020 at 02:41, Arend Van Spriel
<arend.vanspriel at broadcom.com> wrote:

Hi Arend,
Thank you for the review!

> On November 7, 2020 6:25:15 PM Taehee Yoo <ap420073 at gmail.com> wrote:
> > If THIS_MODULE is not set, the module would be removed while debugfs is
> > being used.
> > It eventually makes kernel panic.
> Is this really a valid concern in the context of debugs? I tend to say it
> is not. Whenever I am using debugs to debug my driver I make sure to avoid
> removing it.

I think getting rid of every scenario of the kernel panic is the
first priority thing.
So I'm sure that trying to avoid kernel panic is always valid even
in the debugging context.

Thanks a lot!
Taehee Yoo

More information about the ath10k mailing list