[PATCH] ath10k: add option for chip-id based BDF selection

Kalle Valo kvalo at codeaurora.org
Fri Nov 6 02:11:07 EST 2020

Abhishek Kumar <kuabhs at chromium.org> wrote:

> In some devices difference in chip-id should be enough to pick
> the right BDF. Add another support for chip-id based BDF selection.
> With this new option, ath10k supports 2 fallback options.
> The board name with chip-id as option looks as follows
> board name 'bus=snoc,qmi-board-id=ff,qmi-chip-id=320'
> Signed-off-by: Abhishek Kumar <kuabhs at chromium.org>
> Reviewed-by: Douglas Anderson <dianders at chromium.org>
> Tested-by: Douglas Anderson <dianders at chromium.org>
> Tested-by: Abhishek Kumar <kuabhs at chromium.org>

There were few checkpatch warnings which I fixed:

$ ath10k-check
drivers/net/wireless/ath/ath10k/core.c:1501: Alignment should match open parenthesis
drivers/net/wireless/ath/ath10k/core.c:1512: line length of 92 exceeds 90 columns
drivers/net/wireless/ath/ath10k/core.c:1521: line length of 92 exceeds 90 columns

The first one was also what Doug commented. I also added Tested-on tags,
thanks for those. The updated patch is in pending branch (soon).

But is this patch ok to take now? I didn't quite get the conclusion of the



More information about the ath10k mailing list