ath10k: fix return value check in wake_tx_q op

Kalle Valo kvalo at
Sat May 12 02:03:32 PDT 2018

Erik Stromdahl <erik.stromdahl at> wrote:

> ath10k_mac_tx_push_txq returns either a postive integer (length) on
> success or a negative error code on error.
> The "if (ret) break;" statement will thus always break out of the loop
> immediately after ath10k_mac_tx_push_txq has returned (making the loop
> pointless).
> A side effect of this fix is that we will iterate the queue until
> ath10k_mac_tx_push_txq returns -ENOENT. This will make sure the queue is
> not added back to ar->txqs when it is empty. This could potentially
> improve performance somewhat (I have seen a small improvement with SDIO
> devices).
> Signed-off-by: Erik Stromdahl <erik.stromdahl at>
> Signed-off-by: Kalle Valo <kvalo at>

Patch applied to ath-next branch of ath.git, thanks.

e3148cc5fecf ath10k: fix return value check in wake_tx_q op


More information about the ath10k mailing list