[bug report] ath10k: add memory dump support for QCA6174/QCA9377

Dan Carpenter dan.carpenter at oracle.com
Mon Jan 15 02:00:43 PST 2018


Hello Alan Liu,

The patch 703f261dd77f: "ath10k: add memory dump support for
QCA6174/QCA9377" from Dec 22, 2017, leads to the following static
checker warning:

	drivers/net/wireless/ath/ath10k/pci.c:1481 ath10k_pci_dump_memory_section()
	warn: unsigned 'mem_region->section_table.size' is never less than zero.

drivers/net/wireless/ath/ath10k/pci.c
  1470  static int ath10k_pci_dump_memory_section(struct ath10k *ar,
  1471                                            const struct ath10k_mem_region *mem_region,
  1472                                            u8 *buf, size_t buf_len)
  1473  {
  1474          const struct ath10k_mem_section *cur_section, *next_section;
  1475          unsigned int count, section_size, skip_size;
  1476          int ret, i, j;
  1477  
  1478          if (!mem_region || !buf)
  1479                  return 0;
  1480  
  1481          if (mem_region->section_table.size < 0)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Impossible condition

  1482                  return 0;
  1483  
  1484          cur_section = &mem_region->section_table.sections[0];
  1485  
  1486          if (mem_region->start > cur_section->start) {
  1487                  ath10k_warn(ar, "incorrect memdump region 0x%x with section start addrress 0x%x.\n",
  1488                              mem_region->start, cur_section->start);
  1489                  return 0;
  1490          }

regards,
dan carpenter



More information about the ath10k mailing list