[PATCH] v3 ath10k: add LED and GPIO controlling support for various chipsets

[kbuild test robot]

Hi Sebastian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v4.16-rc2]
[also build test ERROR on next-20180219]
[cannot apply to ath6kl/ath-next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/s-gottschall-dd-wrt-com/v3-ath10k-add-LED-and-GPIO-controlling-support-for-various-chipsets/20180219-115402
config: x86_64-federa-25 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/net//wireless/ath/ath10k/core.c: In function 'ath10k_register_gpio_chip':
   drivers/net//wireless/ath/ath10k/core.c:2208:5: warning: "LINUX_VERSION_CODE" is not defined, evaluates to 0 [-Wundef]
    #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0)
        ^~~~~~~~~~~~~~~~~~
   drivers/net//wireless/ath/ath10k/core.c:2208:27: warning: "KERNEL_VERSION" is not defined, evaluates to 0 [-Wundef]
    #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0)
                              ^~~~~~~~~~~~~~
>> drivers/net//wireless/ath/ath10k/core.c:2208:41: error: missing binary operator before token "("
    #if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0)
                                            ^
>> drivers/net//wireless/ath/ath10k/core.c:2211:13: error: 'struct gpio_chip' has no member named 'dev'
     gpio->gchip.dev = ar->dev;
                ^

vim +2211 drivers/net//wireless/ath/ath10k/core.c

  2196	
  2197	/* register GPIO chip */
  2198	static int ath10k_register_gpio_chip(struct ath10k *ar)
  2199	{
  2200		struct ath10k_gpiocontrol *gpio;
  2201		gpio = kzalloc(sizeof(struct ath10k_gpiocontrol), GFP_KERNEL);
  2202		if (!gpio) {
  2203			return -1;
  2204		}
  2205	 
  2206		snprintf(gpio->label, sizeof(gpio->label), "ath10k-%s",
  2207			 wiphy_name(ar->hw->wiphy));
> 2208	#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,5,0)
  2209		gpio->gchip.parent = ar->dev;
  2210	#else
> 2211		gpio->gchip.dev = ar->dev;
  2212	#endif
  2213		gpio->gchip.base = -1;	/* determine base automatically */
  2214		gpio->gchip.ngpio = ar->hw_params.gpio_count;
  2215		gpio->gchip.label = gpio->label;
  2216		gpio->gchip.direction_input = ath10k_gpio_pin_cfg_input;
  2217		gpio->gchip.direction_output = ath10k_gpio_pin_cfg_output;
  2218		gpio->gchip.get_direction = ath10k_gpio_pin_get_dir;
  2219		gpio->gchip.get = ath10k_gpio_pin_get;
  2220		gpio->gchip.set = ath10k_gpio_pin_set;
  2221	
  2222		if (gpiochip_add(&gpio->gchip)) {
  2223			printk(KERN_ERR "Error while registering gpio chip\n");
  2224			return -1;
  2225		}
  2226		gpio->gchip.owner = NULL;
  2227		ar->gpio = gpio;
  2228		gpio->ar = ar;
  2229		return 0;
  2230	}
  2231	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 48116 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/ath10k/attachments/20180219/652bef84/attachment-0001.gz>