[ath6kl:ath10k-pending-sdio-usb 3/29] drivers/net/wireless/ath/ath10k/snoc.c:1340:33: error: incompatible type for argument 2 of 'ath10k_core_register'
kbuild test robot
lkp at intel.com
Sat Apr 28 23:01:42 PDT 2018
tree: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath10k-pending-sdio-usb
head: 202f8c9db2938c55da177b80e83a4b96413c6ddd
commit: c7a6e204c405e743e7bf75951f264a6d35f9aa12 [3/29] ath10k: add struct ath10k_bus_params
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout c7a6e204c405e743e7bf75951f264a6d35f9aa12
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
drivers/net/wireless/ath/ath10k/snoc.c: In function 'ath10k_snoc_probe':
>> drivers/net/wireless/ath/ath10k/snoc.c:1340:33: error: incompatible type for argument 2 of 'ath10k_core_register'
ret = ath10k_core_register(ar, drv_data->hw_rev);
^~~~~~~~
In file included from drivers/net/wireless/ath/ath10k/trace.h:21:0,
from drivers/net/wireless/ath/ath10k/debug.h:23,
from drivers/net/wireless/ath/ath10k/snoc.c:19:
drivers/net/wireless/ath/ath10k/core.h:1146:5: note: expected 'const struct ath10k_bus_params *' but argument is of type 'const enum ath10k_hw_rev'
int ath10k_core_register(struct ath10k *ar,
^~~~~~~~~~~~~~~~~~~~
vim +/ath10k_core_register +1340 drivers/net/wireless/ath/ath10k/snoc.c
17f5559e Govind Singh 2018-04-10 1263
17f5559e Govind Singh 2018-04-10 1264 static int ath10k_snoc_probe(struct platform_device *pdev)
17f5559e Govind Singh 2018-04-10 1265 {
17f5559e Govind Singh 2018-04-10 1266 const struct ath10k_snoc_drv_priv *drv_data;
17f5559e Govind Singh 2018-04-10 1267 const struct of_device_id *of_id;
17f5559e Govind Singh 2018-04-10 1268 struct ath10k_snoc *ar_snoc;
17f5559e Govind Singh 2018-04-10 1269 struct device *dev;
17f5559e Govind Singh 2018-04-10 1270 struct ath10k *ar;
17f5559e Govind Singh 2018-04-10 1271 int ret;
a6a793f9 Govind Singh 2018-04-10 1272 u32 i;
17f5559e Govind Singh 2018-04-10 1273
17f5559e Govind Singh 2018-04-10 1274 of_id = of_match_device(ath10k_snoc_dt_match, &pdev->dev);
17f5559e Govind Singh 2018-04-10 1275 if (!of_id) {
17f5559e Govind Singh 2018-04-10 1276 dev_err(&pdev->dev, "failed to find matching device tree id\n");
17f5559e Govind Singh 2018-04-10 1277 return -EINVAL;
17f5559e Govind Singh 2018-04-10 1278 }
17f5559e Govind Singh 2018-04-10 1279
17f5559e Govind Singh 2018-04-10 1280 drv_data = of_id->data;
17f5559e Govind Singh 2018-04-10 1281 dev = &pdev->dev;
17f5559e Govind Singh 2018-04-10 1282
17f5559e Govind Singh 2018-04-10 1283 ret = dma_set_mask_and_coherent(dev, drv_data->dma_mask);
17f5559e Govind Singh 2018-04-10 1284 if (ret) {
17f5559e Govind Singh 2018-04-10 1285 dev_err(dev, "failed to set dma mask: %d", ret);
17f5559e Govind Singh 2018-04-10 1286 return ret;
17f5559e Govind Singh 2018-04-10 1287 }
17f5559e Govind Singh 2018-04-10 1288
17f5559e Govind Singh 2018-04-10 1289 ar = ath10k_core_create(sizeof(*ar_snoc), dev, ATH10K_BUS_SNOC,
17f5559e Govind Singh 2018-04-10 1290 drv_data->hw_rev, &ath10k_snoc_hif_ops);
17f5559e Govind Singh 2018-04-10 1291 if (!ar) {
17f5559e Govind Singh 2018-04-10 1292 dev_err(dev, "failed to allocate core\n");
17f5559e Govind Singh 2018-04-10 1293 return -ENOMEM;
17f5559e Govind Singh 2018-04-10 1294 }
17f5559e Govind Singh 2018-04-10 1295
17f5559e Govind Singh 2018-04-10 1296 ar_snoc = ath10k_snoc_priv(ar);
17f5559e Govind Singh 2018-04-10 1297 ar_snoc->dev = pdev;
17f5559e Govind Singh 2018-04-10 1298 platform_set_drvdata(pdev, ar);
17f5559e Govind Singh 2018-04-10 1299 ar_snoc->ar = ar;
17f5559e Govind Singh 2018-04-10 1300 ar_snoc->ce.bus_ops = &ath10k_snoc_bus_ops;
17f5559e Govind Singh 2018-04-10 1301 ar->ce_priv = &ar_snoc->ce;
17f5559e Govind Singh 2018-04-10 1302
c963a683 Govind Singh 2018-04-10 1303 ath10k_snoc_resource_init(ar);
c963a683 Govind Singh 2018-04-10 1304 if (ret) {
c963a683 Govind Singh 2018-04-10 1305 ath10k_warn(ar, "failed to initialize resource: %d\n", ret);
c963a683 Govind Singh 2018-04-10 1306 goto err_core_destroy;
c963a683 Govind Singh 2018-04-10 1307 }
c963a683 Govind Singh 2018-04-10 1308
c963a683 Govind Singh 2018-04-10 1309 ath10k_snoc_setup_resource(ar);
c963a683 Govind Singh 2018-04-10 1310 if (ret) {
c963a683 Govind Singh 2018-04-10 1311 ath10k_warn(ar, "failed to setup resource: %d\n", ret);
c963a683 Govind Singh 2018-04-10 1312 goto err_core_destroy;
c963a683 Govind Singh 2018-04-10 1313 }
c963a683 Govind Singh 2018-04-10 1314 ret = ath10k_snoc_request_irq(ar);
c963a683 Govind Singh 2018-04-10 1315 if (ret) {
c963a683 Govind Singh 2018-04-10 1316 ath10k_warn(ar, "failed to request irqs: %d\n", ret);
c963a683 Govind Singh 2018-04-10 1317 goto err_release_resource;
c963a683 Govind Singh 2018-04-10 1318 }
a6a793f9 Govind Singh 2018-04-10 1319
a6a793f9 Govind Singh 2018-04-10 1320 ar_snoc->vreg = vreg_cfg;
a6a793f9 Govind Singh 2018-04-10 1321 for (i = 0; i < ARRAY_SIZE(vreg_cfg); i++) {
a6a793f9 Govind Singh 2018-04-10 1322 ret = ath10k_get_vreg_info(ar, dev, &ar_snoc->vreg[i]);
a6a793f9 Govind Singh 2018-04-10 1323 if (ret)
a6a793f9 Govind Singh 2018-04-10 1324 goto err_free_irq;
a6a793f9 Govind Singh 2018-04-10 1325 }
a6a793f9 Govind Singh 2018-04-10 1326
a6a793f9 Govind Singh 2018-04-10 1327 ar_snoc->clk = clk_cfg;
a6a793f9 Govind Singh 2018-04-10 1328 for (i = 0; i < ARRAY_SIZE(clk_cfg); i++) {
a6a793f9 Govind Singh 2018-04-10 1329 ret = ath10k_get_clk_info(ar, dev, &ar_snoc->clk[i]);
a6a793f9 Govind Singh 2018-04-10 1330 if (ret)
a6a793f9 Govind Singh 2018-04-10 1331 goto err_free_irq;
a6a793f9 Govind Singh 2018-04-10 1332 }
a6a793f9 Govind Singh 2018-04-10 1333
a6a793f9 Govind Singh 2018-04-10 1334 ret = ath10k_hw_power_on(ar);
a6a793f9 Govind Singh 2018-04-10 1335 if (ret) {
a6a793f9 Govind Singh 2018-04-10 1336 ath10k_err(ar, "failed to power on device: %d\n", ret);
a6a793f9 Govind Singh 2018-04-10 1337 goto err_free_irq;
a6a793f9 Govind Singh 2018-04-10 1338 }
a6a793f9 Govind Singh 2018-04-10 1339
c963a683 Govind Singh 2018-04-10 @1340 ret = ath10k_core_register(ar, drv_data->hw_rev);
c963a683 Govind Singh 2018-04-10 1341 if (ret) {
c963a683 Govind Singh 2018-04-10 1342 ath10k_err(ar, "failed to register driver core: %d\n", ret);
a6a793f9 Govind Singh 2018-04-10 1343 goto err_hw_power_off;
c963a683 Govind Singh 2018-04-10 1344 }
a6a793f9 Govind Singh 2018-04-10 1345
17f5559e Govind Singh 2018-04-10 1346 ath10k_dbg(ar, ATH10K_DBG_SNOC, "snoc probe\n");
17f5559e Govind Singh 2018-04-10 1347 ath10k_warn(ar, "Warning: SNOC support is still work-in-progress, it will not work properly!");
17f5559e Govind Singh 2018-04-10 1348
c963a683 Govind Singh 2018-04-10 1349 return 0;
c963a683 Govind Singh 2018-04-10 1350
a6a793f9 Govind Singh 2018-04-10 1351 err_hw_power_off:
a6a793f9 Govind Singh 2018-04-10 1352 ath10k_hw_power_off(ar);
a6a793f9 Govind Singh 2018-04-10 1353
c963a683 Govind Singh 2018-04-10 1354 err_free_irq:
c963a683 Govind Singh 2018-04-10 1355 ath10k_snoc_free_irq(ar);
c963a683 Govind Singh 2018-04-10 1356
c963a683 Govind Singh 2018-04-10 1357 err_release_resource:
c963a683 Govind Singh 2018-04-10 1358 ath10k_snoc_release_resource(ar);
c963a683 Govind Singh 2018-04-10 1359
c963a683 Govind Singh 2018-04-10 1360 err_core_destroy:
c963a683 Govind Singh 2018-04-10 1361 ath10k_core_destroy(ar);
c963a683 Govind Singh 2018-04-10 1362
17f5559e Govind Singh 2018-04-10 1363 return ret;
17f5559e Govind Singh 2018-04-10 1364 }
17f5559e Govind Singh 2018-04-10 1365
:::::: The code at line 1340 was first introduced by commit
:::::: c963a683e70151dc458e9a85ed4b366b09f65e57 ath10k: add resource init and deinit for WCN3990
:::::: TO: Govind Singh <govinds at codeaurora.org>
:::::: CC: Kalle Valo <kvalo at codeaurora.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 65229 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/ath10k/attachments/20180429/29fd7456/attachment-0001.gz>
More information about the ath10k
mailing list