[PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

Roopa Prabhu roopa at cumulusnetworks.com
Sun Apr 22 14:15:53 PDT 2018

On Sun, Apr 22, 2018 at 11:54 AM, David Miller <davem at davemloft.net> wrote:
> From: Johannes Berg <johannes at sipsolutions.net>
> Date: Thu, 19 Apr 2018 17:26:57 +0200
>> On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote:
>>> Maybe this could be in followup patches?  It's going to touch a lot of files,
>>> and might be hell to get merged all at once, and I've never used spatch, so
>>> just maybe someone else will volunteer that part :)
>> I guess you'll have to ask davem. :)
> Well, first of all, I really don't like this.
> The first reason is that every time I see interface foo become foo2,
> foo3 is never far behind it.
> If foo was not extensible enough such that we needed foo2, we beter
> design the new thing with explicitly better extensibility in mind.
> Furthermore, what you want here is a specific filter.  Someone else
> will want to filter on another criteria, and the next person will
> want yet another.
> This needs to be properly generalized.
> And frankly if we had moved to ethtool netlink/devlink by now, we
> could just add a netlink attribute for filtering and not even be
> having this conversation.


Also, the RTM_GETSTATS api was added to improve stats query efficiency
(with filters).
 we should look at it  to see if this fits there. Keeping all stats
queries in one place will help.

More information about the ath10k mailing list