[PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command.

Johannes Berg johannes at sipsolutions.net
Thu Apr 19 08:26:57 PDT 2018

On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote:
> In order to efficiently parse lots of stats over and over again, I probe
> the stat names once on startup, map them to the variable I am trying to use
> (since different drivers may have different names for the same basic stat),
> and then I store the stat index.
> On subsequent stat reads, I just grab stats and go right to the index to
> store the stat.
> If the stats indexes change, that will complicate my logic quite a bit.

That's a good point.

> Maybe the flag could be called:  ETHTOOL_GS2_NO_REFRESH_FW ?

Sounds more to the point to me, yeah.

> > 
> > Also, wrt. the rest of the patch, I'd argue that it'd be worthwhile to
> > write the spatch and just add the flags argument to "get_ethtool_stats"
> > instead of adding a separate method - internally to the kernel it's not
> > that hard to change.
> Maybe this could be in followup patches?  It's going to touch a lot of files,
> and might be hell to get merged all at once, and I've never used spatch, so
> just maybe someone else will volunteer that part :)

I guess you'll have to ask davem. :)


More information about the ath10k mailing list