[PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets
s.gottschall at dd-wrt.com
Fri Apr 6 01:10:42 PDT 2018
Am 06.04.2018 um 10:07 schrieb Kalle Valo:
> Sebastian Gottschall <s.gottschall at dd-wrt.com> writes:
>> i have some comments about your check warnings.
>> some of them are bogus. for instance they advise to use "unsigned int"
>> instead of "unsigned". this might be better, but
>> the original kernel header uses "unsigned" as api definition. so i
>> decided to use the same declarations here.
> Sure, but using "unsigned int" won't create any harm either.
>> for the rest like whitespaces i will make a new version and remove them
> You missed my comment in my earlier mail that I'll send the next
> version. I have already fixed all the warnings so let me submit it. I'll
> do also some other changes.
oh okay. thank you. then forget all the rest. i will take care of these
issues with the next patch i submit
Mit freundlichen Grüssen / Regards
Sebastian Gottschall / CTO
NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
email: s.gottschall at dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565
More information about the ath10k