[v3] ath10k: rebuild crypto header in rx data frames

Sebastian Gottschall s.gottschall at dd-wrt.com
Tue Oct 31 08:07:37 PDT 2017


Am 31.10.2017 um 16:00 schrieb Kalle Valo:
> Sebastian Gottschall <s.gottschall at dd-wrt.com> writes:
>
>> the following patchlines in the v3 patch look wrong
>>
>> +               /* ICV */
>> +               if (status->flag & RX_FLAG_ICV_STRIPPED &&
>> +                   enctype != HTT_RX_MPDU_ENCRYPT_AES_CCM_WPA2)
>> +                       skb_trim(msdu, msdu->len -
>> +                                ath10k_htt_rx_crypto_tail_len(ar,
>> enctype));
>>
>>
>> the enctype != wpa2 isnt enough since it also belongs to ccmp-256,
>> gcmp modes etc.
> 4.14 doesn't support CCMP-256 nor GCMP modes yet. Did you check the
> separate patch for 4.15:

for me ccmp-256 and gcmp works but my current tree is based on a very 
recent mac80211 version

but did not check if this support is included in 4.14 since i'm 
developing embedded wireless firmwares on different kernel versions 
using wireless backports based on recent mac80211 /ath10k etc. versions

>
> https://patchwork.kernel.org/patch/10029097/
thanks for notifying me. havent seen it
>

-- 
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall at dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565




More information about the ath10k mailing list