[PATCH V5 1/5] mac80211: Enable TDLS peer buffer STA feature
Johannes Berg
johannes at sipsolutions.net
Wed Oct 11 04:07:22 PDT 2017
> +++ b/include/net/cfg80211.h
> @@ -3249,6 +3249,8 @@ struct cfg80211_ops {
> * beaconing mode (AP, IBSS, Mesh, ...).
> * @WIPHY_FLAG_HAS_STATIC_WEP: The device supports static WEP key
> installation
> * before connection.
> + * @WIPHY_FLAG_SUPPORT_TDLS_BUFFER_ST: Device support buffer STA
> when TDLS is
> + * established.
There's a typo (missing A) here.
However, I don't see a reason for this to be a WIPHY flag rather than a
mac80211 hw flag (enum ieee80211_hw_flags) since you only use it in
mac80211.
In reality, adding WIPHY flags should be really rare - only if
*cfg80211* needs to know something, but *userspace* doesn't...
If cfg80211 doesn't care, add to mac80211. If userspace cares, add to
extended nl80211 flags instead :)
johannes
More information about the ath10k
mailing list