[PATCH] Per chain RSSI reporting

Kalle Valo kvalo at qca.qualcomm.com
Wed May 31 06:05:59 PDT 2017

Norik Dzhandzhapanyan <norikd at ethertronics.com> writes:

> Inserting the smoothing function here is motivated by what we see as
> 'spikes' in rssi data under weak rssi conditions. Figured its best to
> get rid of the 'bogus' data as close to the source as possible. Also
> to minimize the impact on the changes.
> I believe the averaging that happens at higher levels is based on EWMA
> macros in net/mac80211/sta_info.c which not wifi card/chipset
> specific. Didn't want to touch that since other cards seem to not have
> this spikey behavior. And, it doesnt seem to have an effect on the
> ath10k data anyway (iw reports the exact same values for both).
> I wonder if it would be acceptable to pass a module load time
> parameter which would indicate an average factor with 0 (as default)
> to indicate no averaging?

I don't know what Johannes thinks, but in my opinion this kind of
smoothing should be in mac80211 and not in drivers. The driver should be
as simple as possible.

Kalle Valo

More information about the ath10k mailing list