ath10k: merge extended peer info data with existing peers info
kvalo at qca.qualcomm.com
Fri May 5 05:51:16 PDT 2017
Christian Lamparter <chunkeey at googlemail.com> wrote:
> The 10.4 firmware adds extended peer information to the
> firmware's statistics payload. This additional info is
> stored as a separate data field. During review of
> "ath10k: add accounting for the extended peer statistics" 
> Mohammed Shafi Shajakhan commented that the extended peer statistics
> lists are of little use:"... there is not much use in appending
> the extended peer stats (which gets periodically updated) to the
> linked list '&ar->debug.fw_stats.peers_extd)' and should we get
> rid of the below (and the required cleanup as well)
> since rx_duration is getting updated periodically to the per sta
> This patch replaces the extended peers list with a lookup and
> puts the retrieved data (rx_duration) into the existing
> ath10k_fw_stats_peer entry that was created earlier.
>  <https://firstname.lastname@example.org>
> Cc: Mohammed Shafi Shajakhan <mohammed at codeaurora.org>
> Signed-off-by: Christian Lamparter <chunkeey at googlemail.com>
The discussion with this bug was quite hard to follow, so what is the
conclusion from this? The patch still applies using three way merge but there
are compilation errors:
drivers/net/wireless/ath/ath10k/debug.c: In function 'ath10k_debug_fw_stats_process':
drivers/net/wireless/ath/ath10k/debug.c:388:4: error: implicit declaration of function 'ath10k_fw_extd_stats_peers_free' [-Werror=implicit-function-declaration]
drivers/net/wireless/ath/ath10k/debug.c:388:55: error: 'struct ath10k_fw_stats' has no member named 'peers_extd'
drivers/net/wireless/ath/ath10k/debug.c:400:32: error: 'struct ath10k_fw_stats' has no member named 'peers_extd'
drivers/net/wireless/ath/ath10k/debug.c:401:31: error: 'struct ath10k_fw_stats' has no member named 'peers_extd'
I admit that I didn't look this patch very carefully, but I'm not really seeing
how this patch makes things better? wmi.c gets more complicated and a new
ifdef is added. We have tried hard to keep all ar->debug access in debug.c,
this way there's no need to sprinkle ifdefs in the code.
More information about the ath10k