QCA4019: calibration files and board files

[Sven Eckelmann]

On Donnerstag, 9. Februar 2017 15:56:59 CET akolli at codeaurora.org wrote:
[...]
> Thanks for pointing this, I broke the sequence in qsdk while loading cal 
> data
> from flash MTD partitions. I will revert these changes in QSDK patch[1].
> 
> @@ -224,21 +224,13 @@
>   +		 * from board data content and caldata content downloaded in
>   +		 * previous steps.
>   +		*/
> -+		goto load_bdata_and_run_otp;
> ++		goto done;
>   +	}
>   +
>    	ret = ath10k_download_cal_file(ar, ar->cal_file);
>    	if (ret == 0) {
>    		ar->cal_mode = ATH10K_CAL_MODE_FILE;
> -@@ -1401,6 +1520,7 @@ static int ath10k_download_cal_data(stru
> - 		   "boot did not find target EEPROM entry, try OTP next: %d\n",
> - 		   ret);
> -
> -+load_bdata_and_run_otp:
> - 	ret = ath10k_download_and_run_otp(ar);
> - 	if (ret) {
> - 		ath10k_err(ar, "failed to run otp: %d\n", ret);
> -@@ -2024,6 +2144,8 @@ static int ath10k_core_probe_fw(struct a
> +@@ -2025,6 +2144,8 @@ static int ath10k_core_probe_fw(struct a
>    			   "could not load pre cal data: %d\n", ret);
>    	}

We now got answer from QCA support (Eric Guo, case 02807752). He told us now
that the data on the ART partition is *not* the pre-calibration data
and instead is the full calibration data (he is is not really clear about that
part).

It looks to me now that this information is contradicting your implementation
(which now loads the data from 0:ART partition [1] like pre-cal data [2] and
then loads the board-2.bin [3]). 

I have doubt regarding his explanation but I got no actual spec - only
information which seems to be contradicting (or to vague) . Is is possible
to get some confirmation from you about whether the data from the 0:ART
partition is pre-cal data or not and whether the board-2.bin should be
used when the data from 0:ART is used.

It could also be that Eric and I are just using the terms "pre-cal" and
"calibration" data differently. My understanding until now was that:

 * pre-cal data + board-2.bin info == actual calibration data

Maybe he is using a different definitions like

 * pre-cal data == some incomplete calibration data from somewhere else
                   (he never specified it - just that it exists)
 * calibration data == incomplete calibration data from 0:ART
                       (what I've described in the past as pre-cal data)
 * (pre-cal or calibration data) + board-2.bin info == actual calibration data

Would be nice if this confusion could be cleared up by you.

Kind regards,
	Sven

[1] https://source.codeaurora.org/quic/qsdk/oss/system/feeds/wlan-open/tree/mac80211/patches/a00-0058-ath10k-add-qca40xx-mtd-caldata-download-sup.patch?id=b9910f7bd128b719562b6807388ef5519e7676c1#n123
[2] https://source.codeaurora.org/quic/qsdk/oss/system/feeds/wlan-open/tree/mac80211/patches/a00-0058-ath10k-add-qca40xx-mtd-caldata-download-sup.patch?id=b9910f7bd128b719562b6807388ef5519e7676c1#n213
[3] https://source.codeaurora.org/quic/qsdk/oss/system/feeds/wlan-open/tree/mac80211/patches/a00-0058-ath10k-add-qca40xx-mtd-caldata-download-sup.patch?id=b9910f7bd128b719562b6807388ef5519e7676c1#n222

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/ath10k/attachments/20170228/7492e233/attachment.sig>