[2/6] ath10k: refactor firmware crashdump code to coredump.c

Kalle Valo kvalo at qca.qualcomm.com
Wed Aug 16 23:49:40 PDT 2017


Kalle Valo <kvalo at qca.qualcomm.com> writes:

> Kalle Valo <kvalo at qca.qualcomm.com> wrote:
>
>> In preparation to add RAM dump support. No functional changes, only moving code
>> and renaming function names.
>> 
>> Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>
>
> With only this patch applied, and CONFIG_DEV_COREDUMP disabled, there's a build error:
>
> drivers/net/wireless/ath/ath10k/coredump.c:24:30: error: redefinition
> of 'ath10k_coredump_new'
> drivers/net/wireless/ath/ath10k/coredump.c:130:5: error: redefinition
> of 'ath10k_coredump_submit'

Fixed in pending branch like this:

--- a/drivers/net/wireless/ath/ath10k/Makefile
+++ b/drivers/net/wireless/ath/ath10k/Makefile
@@ -20,7 +20,7 @@ ath10k_core-$(CONFIG_ATH10K_TRACING) += trace.o
 ath10k_core-$(CONFIG_THERMAL) += thermal.o
 ath10k_core-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o
 ath10k_core-$(CONFIG_PM) += wow.o
-ath10k_core-$(CONFIG_ATH10K_DEBUGFS) += coredump.o
+ath10k_core-$(CONFIG_DEV_COREDUMP) += coredump.o

-- 
Kalle Valo


More information about the ath10k mailing list