[PATCH] QCA9984 VHT160 support

Sebastian Gottschall s.gottschall at dd-wrt.com
Mon Oct 10 18:30:50 PDT 2016

Am 10.10.2016 um 18:06 schrieb Valo, Kalle:
> Kalle Valo <kvalo at qca.qualcomm.com> writes:
>> Sebastian Gottschall <s.gottschall at dd-wrt.com> writes:
>>> This patch adds full VHT160 support for QCA9984 chipsets
>>> Tested on Netgear R7800. 80+80 is possible, but disabled so far since
>>> it seems to contain glitches like missing vht station flags (this may
>>> be firmware or mac80211 related)
>> There are some compilation and checkpatch warnings. Also you forgot to
>> CC linux-wireless and sent the patch as an attachment. I'll send v2 to
>> fix those.
gen_dbglog_cfg? i did not touch anything on this struct in my patch. 
this warning doesnt seem to belong to my patch
> Forgot the actual warnings:
> drivers/net/wireless/ath/ath10k/wmi-tlv.c:3520:2: warning: initialization from incompatible pointer type [enabled by default]
> drivers/net/wireless/ath/ath10k/wmi-tlv.c:3520:2: warning: (near initialization for 'wmi_tlv_ops.gen_dbglog_cfg') [enabled by default]
> drivers/net/wireless/ath/ath10k/wmi-tlv.c:3520:27: warning: incorrect type in initializer (incompatible argument 2 (different type sizes))
> drivers/net/wireless/ath/ath10k/wmi-tlv.c:3520:27:    expected struct sk_buff *( *gen_dbglog_cfg )( ... )
> drivers/net/wireless/ath/ath10k/wmi-tlv.c:3520:27:    got struct sk_buff *( static [toplevel] *<noident> )( ... )
> drivers/net/wireless/ath/ath10k/wmi-tlv.h:546: code indent should use tabs where possible
> drivers/net/wireless/ath/ath10k/wmi-tlv.h:546: please, no spaces at the start of a line
> drivers/net/wireless/ath/ath10k/mac.c:2556: braces {} should be used on all arms of this statement
> drivers/net/wireless/ath/ath10k/mac.c:2560: line over 90 characters
> drivers/net/wireless/ath/ath10k/mac.c:4301: line over 90 characters
> drivers/net/wireless/ath/ath10k/mac.c:4301: braces {} are not necessary for single statement blocks

Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz:  Berliner Ring 101, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
email: s.gottschall at dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565

More information about the ath10k mailing list