How is tx-flushing supposed to work now?

Michal Kazior michal.kazior at tieto.com
Wed Mar 30 22:23:02 PDT 2016


On 30 March 2016 at 22:50, Ben Greear <greearb at candelatech.com> wrote:
> On 03/30/2016 03:38 AM, Michal Kazior wrote:
>>
>> On 29 March 2016 at 21:26, Ben Greear <greearb at candelatech.com> wrote:
>>>
>>> When we have multiple vdevs, and the 10.4.3 firmware with the tx-push
>>> logic,
>>> how is flushing supposed to work?
>>
>>
>> This isn't really as much about pull-push logic in 10.4.3 as it is
>> about wake_tx_queue() in general, is it?
>
>
> In particular, I am curious about the ar->txqs, and the
> ath10k_mac_tx_push_pending
> method.  Should we purge the ar->txqs as part of the flush logic?

No need to. If mac80211 purges some txqs ath10k will eventually visit
an empty txq and remove it (push/threshold mode). If ath10k FW is in
pull-push it'll prompt fetch-ind event which will 1) submit 0 frames
2) update hostq state.


Michał



More information about the ath10k mailing list