[PATCH v1 3/3] ath10k: Enable parsing per station rx duration for 10.4
Mohammed Shafi Shajakhan
mohammed at codeaurora.org
Wed Mar 23 06:03:49 PDT 2016
Hi Kalle,
On Wed, Mar 23, 2016 at 01:00:01PM +0000, Valo, Kalle wrote:
> Mohammed Shafi Shajakhan <mohammed at qti.qualcomm.com> writes:
>
> > From: Mohammed Shafi Shajakhan <mohammed at qti.qualcomm.com>
> >
> > Rx duration support for per station is part of extended peer
> > stats, enable provision to parse the same and provide backward
> > compatibility based on the 'stats_id' event
> >
> > Signed-off-by: Mohammed Shafi Shajakhan <mohammed at qti.qualcomm.com>
>
> There was a new sparse warning:
>
> drivers/net/wireless/ath/ath10k/wmi.c:2978:42: warning: incorrect type in assignment (different base types)
> drivers/net/wireless/ath/ath10k/wmi.c:2978:42: expected unsigned int [unsigned] [usertype] rx_duration
> drivers/net/wireless/ath/ath10k/wmi.c:2978:42: got restricted __le32 const [usertype] rx_duration
>
> I fixed it like this in the pending branch, please double check:
[shafi] thanks for fixing this, sorry i missed this.
>
> --- a/drivers/net/wireless/ath/ath10k/wmi.c
> +++ b/drivers/net/wireless/ath/ath10k/wmi.c
> @@ -2975,7 +2975,7 @@ static int ath10k_wmi_10_4_op_pull_fw_stats(struct ath10k *ar,
> ath10k_wmi_10_4_pull_peer_stats(&src->common, dst);
> /* FIXME: expose 10.4 specific values */
> if (extd_peer_stats)
> - dst->rx_duration = src->rx_duration;
> + dst->rx_duration = __le32_to_cpu(src->rx_duration);
>
> list_add_tail(&dst->list, &stats->peers);
> }
>
regards,
shafi
More information about the ath10k
mailing list