[PATCH v3] ath10k: Fix 10.4 extended peer stats update

[Valo, Kalle]

Mohammed Shafi Shajakhan <mohammed at codeaurora.org> writes:

> Hi Kalle,
>
> On Thu, Jun 30, 2016 at 10:49:02AM +0000, Valo, Kalle wrote:
>> Kalle Valo <kvalo at qca.qualcomm.com> writes:
>> 
>> >> @@ -261,6 +263,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = {
>> >>  			.board = QCA4019_HW_1_0_BOARD_DATA_FILE,
>> >>  			.board_size = QCA4019_BOARD_DATA_SZ,
>> >>  			.board_ext_size = QCA4019_BOARD_EXT_DATA_SZ,
>> >> +			.extd_peer_stats = true,
>> >>  		},
>> >>  	},
>> >>  };
>> >
>> > This is not a hardware feature so hw_params is not really the right
>> > place to handle this. In the pending branch I tried to solve this a bit
>> > differently:
>> >
>> > https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=ecf4daadc7677518ec7185dbddab959ac6e2db96
>> >
>> > I added a bool "extended" to struct ath10k_fw_stats which is used to
>> > detect if extended stats are used. Would that work? Please note that I
>> > have only compile tested the patch.
>
> [shafi] thanks for taking time to do this, the change looks fine to me !
> since 'ath10k_sta_update_rx_duration' is called right after 'ath10k_wmi_pull_fw_stats'
> this should properly update the rx_duration based on the current data

Could you also run some tests to make sure? I don't trust my own code :)

-- 
Kalle Valo